On 06/03/2013 08:18 AM, Lee Jones wrote:
> On Mon, 03 Jun 2013, J Keerthy wrote:
>> Add the various binding files for the palmas family of chips. There is a
>> top level MFD binding then a seperate binding for regulators IP blocks on
>> chips.
>> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt
>> b/Documentation/devicetree/bindings/mfd/palmas.txt
>> +Example:
>> +
>> +palmas {
>
> Should this be 'palmas@48 {', as it has an address?
It's common to only include the unit-address (@48) if it's needed to
make the node name unique (i.e. if you had multiple palmas devices).
>> diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
>> b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
>
>> + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
>> + 2 - eco, 3 - forced pwm
>
> I've seen lots of sleep-mode properties, can't we define a generic
> one?
Isn't it HW-specific?
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
