On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
> Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> instantiated in some legacy ARC (Synopsys) FPGA Boards such as
> ARCAngel4/ML50x.
Looks fine to me.
One nit you could fix later and a question.
> diff --git a/drivers/net/ethernet/arc/emac_main.c
> b/drivers/net/ethernet/arc/emac_main.c
[]
> +static int arc_emac_rx(struct net_device *ndev, int budget)
> +{
[]
> + if (net_ratelimit())
> + netdev_err(ndev, "incomplete packed
> received\n");
s/packed/packet/
> + rxbd->data = (unsigned char *)cpu_to_le32(rx_buff->skb->data);
32 bit only. Should the Kconfig block have some arch_arc dependency
so it can't get compiled for 64 bit systems?
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
