On Mon, Jul 15, 2013 at 02:40:39PM +0800, Robin Gong wrote:
> > > +static const struct of_device_id pfuze_dt_ids[] = {
> > > + { .compatible = "fsl,pfuze100", .data = (void *)PFUZE_ID_PFUZE100},
> >
> > You do not use .data in the driver at all, and can just drop it.
> >
> good catch. .driver_data of i2c_device_id and .data of of_device_id are two
> different ways to let driver know which chip used now by DTS or not. I should
> use them to know which chip used now ,although I can know by reading chipid
> register.
>
If you can figure out the chip ID from hardware, it should be used as
the preference over compatible and .driver_data.
Shawn
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
