On Wed, 2013-07-17 at 13:34 +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_...@trendmicro.com.cn> > > Add the missing iounmap() before return from msm_request_port() > in the error handling case. >
Reviewed-by: Ivan T. Ivanov <iiva...@mm-sol.com> Regards, Ivan > Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn> > --- > drivers/tty/serial/msm_serial.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c > index 2c6cfb3..0b38b28 100644 > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -637,7 +637,7 @@ static int msm_request_port(struct uart_port *port) > if (!request_mem_region(gsbi_resource->start, size, > "msm_serial")) { > ret = -EBUSY; > - goto fail_release_port; > + goto fail_release_port_membase; > } > > msm_port->gsbi_base = ioremap(gsbi_resource->start, size); > @@ -651,6 +651,8 @@ static int msm_request_port(struct uart_port *port) > > fail_release_gsbi: > release_mem_region(gsbi_resource->start, size); > +fail_release_port_membase: > + iounmap(port->membase); > fail_release_port: > release_mem_region(port->mapbase, size); > return ret; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss