Hello.

> The following devices/functionalities were added:
>  * Main and secondary UARTs.
>  * i2c and the pcf8563 device.
>  * Ethernet.
>  * NAND.
>  * The BP1 button.
>  * The LED.
>  * Watchdog.
>  * SD.
>  * USB host.
...

> +             reg_3p3v: regulator@0 {
> +                     reg = <0>;
> +                     compatible = "regulator-fixed";
> +                     regulator-name = "3P3V";
> +                     regulator-min-microvolt = <3300000>;
> +                     regulator-max-microvolt = <3300000>;
> +                     regulator-always-on;

"regulator-always-on" make no sense for virtual supplies.

...
> +             pinctrl_uart1: uart1grp {
> +                     fsl,pins = <MX53_UART1_PINGRP2>;
> +             };
> +
> +             pinctrl_uart2: uart2grp {
> +                     fsl,pins = <MX53_UART2_PINGRP2>;
> +             };
> +     };
> +};
> +
> +&uart1 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&pinctrl_uart1>;
> +     fsl,uart-has-rtscts;

So if you use "fsl,uart-has-rtscts", should you add MX53_UART1_PINGRP3
into pinctls too?

---

Reply via email to