> -----Original Message----- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Thursday, January 16, 2014 7:03 PM > To: Lu Jingchang-B35083 > Cc: vinod.k...@intel.com; dan.j.willi...@intel.com; shawn....@linaro.org; > pawel.m...@arm.com; mark.rutl...@arm.com; swar...@wwwdotorg.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > devicetree@vger.kernel.org; Wang Huan-B18965 > Subject: Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support > > On Thursday 16 January 2014, Jingchang Lu wrote: > > Add Freescale enhanced direct memory(eDMA) controller support. > > This module can be found on Vybrid and LS-1 SoCs. > > > > Signed-off-by: Alison Wang <b18...@freescale.com> > > Signed-off-by: Jingchang Lu <b35...@freescale.com> > > Very nice! All my previous comments have been addressed, so > > Acked-by: Arnd Bergmann <a...@arndb.de> > > One small comment still: > > > + > > +static DEFINE_MUTEX(fsl_edma_mutex); > > + > > I think this mutex should be part of struct fsl_edma_engine, not global. Yes, it should be for each edma controller, I will define it in struct fsl_edma_engine. Thanks.
Best Regards, Jingchang
