From: Of Vince Bridgers
> Hello Florian, thank you for taking the time to comments. My responses inline.
>
> On Sun, Mar 2, 2014 at 6:59 PM, Florian Fainelli <f.faine...@gmail.com> wrote:
> > Hello Vince,
> >
> > It might help reviewing the patches by breaking the patches into:
> >
> > - the SGDMA bits
> > - the MSGDMA bits
> > - the Ethernet MAC driver per-se
>
> I'll break down the next submission.
>
> >
> > BTW, it does look like the SGDMA code could/should be a dmaengine driver?
>
> I did consider this, but after studying the dmaengine api I found the
> API definitions and semantics were not a match to the way the SGDMA
> and MSGDMA behave collectively. Moreover, I could not find an example
> of an Ethernet driver that made use of the dmaengine API - only the
> Micrel driver seems to use it. When studying what components actually
> used the dmaengine API I concluded the dmaengine API was defined for
> use cases different than Ethernet.
It is probably reasonable to expect that the SGDMA is instantiated for the
sole use of the ethernet block - it probably wants two of them, and then
treat it as part of the ethernet hardware.
I've not looked at the TSE or SGDMA, but I suspect you could require that
they be placed at adjacent Avalon addresses. So that they are effectively
a single device. Qsys might even let you define such a beast.
David
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
