On 01.05.2014 17:40, Doug Anderson wrote:
Arun,
On Wed, Apr 30, 2014 at 4:08 AM, Arun Kumar K <arun...@samsung.com> wrote:
+ memory {
+ reg = <0x20000000 0x80000000>;
As mentioned in the other thread, I think this should be 0 0
I guess it may depend on your boards, but DT might contain safe default
configuration that would work on all variants, so if you have for
example 1 GiB and 2 GiB variants, 1 GiB configuration here should be
fine to get the board running even without a bootloader that could
inject remaining data.
+&pinctrl_0 {
+ tpm_irq: tpm-irq {
+ samsung,pins = "gpx1-0";
+ samsung,pin-function = <0>;
+ samsung,pin-pud = <0>;
Is there any way to use the #defines PIN_PULL_NONE here?
I wonder if we already have this kind of #define defined. Keep in mind
that this value is specific for Exynos SoCs, so we would need to define
it in Exynos-specific header, like include/dt-bindings/pinctrl/exynos.h.
+&pinctrl_3 {
+ backlight_pwm: backlight-pwm {
+ samsung,pins = "gpb2-0";
+ samsung,pin-function = <2>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
The PWM probably belongs in exynos5420-pinctrl.dtsi (though you'd need
to call it by a more generic name since it could be used for something
other than a backlight).
Yes, please add generic pinctrl nodes for all PWM outputs on the SoC to
exynos5420-pinctrl.dtsi, as done in exynos4x12-pinctrl.dtsi (see
pwmX-out nodes).
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
