On Thu, May 22, 2014 at 02:47:07PM +0530, Tushar Behera wrote:

> +     max98090->mclk = devm_clk_get(codec->dev, "mclk");
> +     if (!IS_ERR(max98090->mclk))
> +             clk_prepare_enable(max98090->mclk);
> +

Ths doesn't handle deferred probe, we need to at least return an error
if we get -EPROBE_DEFER.  

It'd also be better to move the enabling to set_bias_level() if possible
(I don't know if the clock is needed for register access) though less
essential.

Attachment: signature.asc
Description: Digital signature

Reply via email to