On 07/16/2014 02:55 PM, Antoine Ténart wrote:
Hi Varka,

On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote:
On 07/16/2014 01:55 PM, Antoine Ténart wrote:
+static const struct of_device_id phy_berlin_sata_of_match[] = {
+       {
+               .compatible = "marvell,berlin2-usb-phy",
+               .data = &phy_berlin_pll_dividers[0],
+       },
+       {
+               .compatible = "marvell,berlin2cd-usb-phy",
+               .data = &phy_berlin_pll_dividers[1],
+       },
+       { },
+};
+MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
+
It looks good if we move this after probe().. So that we can see of_match_table 
directly...
We use the of match table in the probe, when calling of_match_device().

+static int phy_berlin_usb_probe(struct platform_device *pdev)
+{
+       const struct of_device_id *match =
+               of_match_device(phy_berlin_sata_of_match, &pdev->dev);

We are updating of_match_table in platform_driver struct.

Every driver follows the concept of giving the of_device_ids
above the platform_driver declaration...

Here.

Antoine

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to