On 09/29/14 17:34, Bjorn Andersson wrote: > + > +#define GET_RX_CHANNEL_INFO(channel, param) \ > + (channel->rx_info_word ? \ > + channel->rx_info_word->param : \ > + channel->rx_info->param) > + > +#define GET_TX_CHANNEL_INFO(channel, param) \ > + (channel->rx_info_word ? \ > + channel->tx_info_word->param : \ > + channel->tx_info->param) > + > +#define SET_RX_CHANNEL_INFO(channel, param, value) \ > + (channel->rx_info_word ? \ > + (channel->rx_info_word->param = value) : \ > + (channel->rx_info->param = value)) > + > +#define SET_TX_CHANNEL_INFO(channel, param, value) \ > + (channel->rx_info_word ? \
Drive-by review: Should this be tx_info_word? Given that it works I wonder why not just have a flag indicating if we should use word aligned read/write vs. byte aligned. > + (channel->tx_info_word->param = value) : \ > + (channel->tx_info->param = value)) > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
