On Wed, Oct 01, 2014 at 04:53:07PM +0200, Boris Brezillon wrote:
[...]
> diff --git a/arch/arm/boot/dts/sama5d3xdm.dtsi 
> b/arch/arm/boot/dts/sama5d3xdm.dtsi
[...]
> +     bl_reg: backlight_regulator {
> +             compatible = "regulator-fixed";
> +             regulator-name = "backlight-power-supply";
> +             regulator-min-microvolt = <5000000>;
> +             regulator-max-microvolt = <5000000>;
> +             status = "disabled";
> +     };
> +
> +     panel_reg: panel_regulator {
> +             compatible = "regulator-fixed";
> +             regulator-name = "panel-power-supply";
> +             regulator-min-microvolt = <3300000>;
> +             regulator-max-microvolt = <3300000>;
> +             status = "disabled";
> +     };
> +
> +     backlight: backlight {
> +             compatible = "pwm-backlight";
> +             pwms = <&hlcdc_pwm 0 50000 0>;
> +             brightness-levels = <0 4 8 16 32 64 128 255>;
> +             default-brightness-level = <6>;
> +             power-supply = <&bl_reg>;
> +             status = "disabled";
> +     };

Why are these all disabled? Patch 11/11 now needs to enable all of them
explicitly for each board that uses this display module.

> +     panel: panel {
> +             compatible = "foxlink,fl500wvr00-a0t", "simple-panel";

"simple-panel" shouldn't be in this list. There's nothing useful a
driver can do by matching on it.

> +             backlight = <&backlight>;
> +             power-supply = <&panel_reg>;
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +             status = "disabled";
> +
> +             port@0 {
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +
> +                     panel_input: endpoint@0 {
> +                             reg = <0>;
> +                             remote-endpoint = <&hlcdc_panel_output>;
> +                     };
>               };

There's no support for OF graphs in simple-panel, so this is unused,
isn't it?

Thierry

Attachment: pgpIhTkIS4GQR.pgp
Description: PGP signature

Reply via email to