Jude, Naidu, On Thu, Nov 20, 2014 at 5:02 AM, <[email protected]> wrote: > From: Jude Abraham <[email protected]> > > This commit adds support for ImgTec PowerDown Controller Watchdog Timer. > > Signed-off-by: Jude Abraham <[email protected]> > Signed-off-by: Naidu Tellapati <[email protected]>
Reviewed-by: Andrew Bresticker <[email protected]> Two small comments you may want to fix if you need to re-spin the series though: > +static struct watchdog_info pdc_wdt_info = { > + .options = WDIOF_SETTIMEOUT | > + WDIOF_KEEPALIVEPING | > + WDIOF_MAGICCLOSE, > + .identity = "IMG PDC Watchdog", > +}; Inconsistent spacing. > + ret = watchdog_init_timeout(&pdc_wdt->wdt_dev, timeout, &pdev->dev); > + if (ret < 0) > + pdc_wdt->wdt_dev.timeout = pdc_wdt->wdt_dev.max_timeout; Maybe print an error here? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
