On 11/21/2014 10:03 AM, Lina Iyer wrote:
+
+static const struct platform_device_info  qcom_cpuidle_info = {

nitpick, why two spaces between info and qcom here?

+       .name   = "qcom_cpuidle",
+       .id     = -1,
+       .data = &lpm_ops,
+       .size_data = sizeof(lpm_ops),
+};

This struct could go on the stack too so that it doesn't lay around forever.


+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("SAW power controller driver");
+MODULE_ALIAS("saw");

"platform:saw" please. Namespacing aliases is good.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to