On Tue, Dec 30, 2014 at 8:28 PM, Rob Herring <robherri...@gmail.com> wrote:
> From: Rob Herring <r...@kernel.org> > > Disable the Versatile PCI DT node when no PCI backplane is detected. This > will prevent the Versatile PCI driver from probing when PCI is not > populated. > > Signed-off-by: Rob Herring <r...@kernel.org> > Cc: Russell King <li...@arm.linux.org.uk> > Cc: Linus Walleij <linus.wall...@linaro.org> (...) > + /* Check if PCI backplane is detected */ > + val = __raw_readl(base + VERSATILE_SYS_PCICTL_OFFSET); I think this kind of random syscon register access should be handled using the mfd/syscon.c hub and looked up in some way to be used by the driver. I'm thinking along the pattern of adding code in drivers/* by the pattern of e.g. drivers/video/fbdev/amba-clcd-versatile.c i.e. an add-on that gets compiled-in only for those platform but still married to the main driver. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html