On Fri, Mar 20, 2015 at 12:02 PM, Mark Rutland <[email protected]> wrote: > While skeleton.dtsi was initially conceived as a simple way to bootstrap > writing a dts, it has proven to be problematic: > > * The #address-cells and #size-cells values used in skeleton.dtsi may > not match what a user wants (e.g. when they need to describe a range > larger than 4GB). > > * For dts files where memory nodes have unit-addresses, it adds a > redundant /memory node, for which the reg entry may not be > appropriately sized (e.g. where #size-cells has been overridden). > > * For dts files which assume that a bootloader will fill in the memory > node(s), no node is present in the dts (and hence there is no attached > comment), making it hard to distinguish these cases from bad dts > files, and masking any warnings dtc may produce w.r.t. missing nodes. > > * The default empty /chosen and /aliases are somewhat useless, and it > would be preferable for dts to fill these in (e.g. for > /aliases/serial0 and /chosen/stdout-path). > > This patch removes skeleton.dtsi from arm64. There are currently no > users, so we can remove it before any appear. > > Signed-off-by: Mark Rutland <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Catalin Marinas <[email protected]> > Cc: Olof Johansson <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Will Deacon <[email protected]>
Acked-by: Rob Herring <[email protected]> > --- > arch/arm64/boot/dts/skeleton.dtsi | 13 ------------- > 1 file changed, 13 deletions(-) > delete mode 100644 arch/arm64/boot/dts/skeleton.dtsi > > Recent comments reminded me to send this. > > I've taken a look in mainline and linux-next and I see no skeleton.dtsi users > in arch/arm64/boot/dts/. > > Mark. > > diff --git a/arch/arm64/boot/dts/skeleton.dtsi > b/arch/arm64/boot/dts/skeleton.dtsi > deleted file mode 100644 > index 38ead82..0000000 > --- a/arch/arm64/boot/dts/skeleton.dtsi > +++ /dev/null > @@ -1,13 +0,0 @@ > -/* > - * Skeleton device tree; the bare minimum needed to boot; just include and > - * add a compatible value. The bootloader will typically populate the memory > - * node. > - */ > - > -/ { > - #address-cells = <2>; > - #size-cells = <1>; > - chosen { }; > - aliases { }; > - memory { device_type = "memory"; reg = <0 0 0>; }; > -}; > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
