Hi, On Fri, Sep 25, 2015 at 10:54:05AM -0500, Andreas Dannenberg wrote: > This patch series extends the driver to also support bq24250/bq24251. > > The bq24250/251/257 devices have a very similar feature set and are > virtually identical from a control register point of view so it made > sense to extend the existing driver rather than submitting a new driver. > In addition to the new device support the driver is also extended to > allow access to some device features previously hidden. Basic and > potentially dangerous charger config parameters affecting the actual > charging of the Li-Ion battery are only configurable through firmware > rather than sysfs properties. However some newly introduced properties > are exposed through sysfs properties as access to them may be desired > from userspace. For example, it is now possible to manually configure > the maximum current drawn from the input source to accommodate different > chargers (0.5A, 1.5A, 2.0A and so on) based on system knowledge a > userspace application may have rather than rely on the auto-detection > mechanism that may not work in all possible scenarios. > > Note that most patches have dependencies on other patches in the series.
I reviewed all patches, those without comments look fine to me. I did not queue them because of the mentioned dependencies on previous patches, which got comments from me. -- Sebastian
signature.asc
Description: PGP signature
