On 2015/10/1 1:39, Mark Brown wrote:
> On Wed, Sep 30, 2015 at 07:05:04PM +0800, Fei Wang wrote:
>
>> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
>> +
>> +hi655x consists of a large and varied group of sub-devices:
>> +
>> +Device Supply Names Description
>> +------ ------------ -----------
>> +hi655x-powerkey : : Powerkey
>> +hi655x-regulator-pmic : : Regulators
>> +hi655x-usbvbus : : USB plug detection
>> +hi655x-pmu-rtc : : RTC
>> +hi655x-coul : : Coulomb
>
> ...counter?
>
> There's no documentation of the bindings for any of the above devices or
> how things are structured, you need to provide binding documentation
> which is understandable standalone. None of the properties are
> documented, nor is the set of regulators supported or how this is
> structured.
OK,i will add them.
>
>> + coul: coul@1 {
>> + compatible = "hisilicon,hi655x-coul";
>> + interrupt-parent = <&pmic>;
>> + interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
>> + interrupt-names = "cl_int_i", "cl_out_i",
>> "cl_in_i", "vbat_int_i";
>> + battery_product_index = <0>;
>
> For example, the "battery_product_index" property here is undocumented.
now on hikey, we only enable hi655x-regulator-pmic function, and regulator is
child node of pmic.do i need to document regulator dt-binding in this file or
create a new regulator dt-binding file?
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
