On Tue, 2003-09-30 at 17:33, Ian Clarke wrote: > Just a sanity check in the RTE code: > > Line 223 in StandardNodeEstimator - is this right : > rtTransferFailed.report(size); > > It looks like it is reporting the size, but shouldn't it be reporting > the time? > > Ian.
This is correct. The value is labeled "ms" in a report, and is used to calculate an estimated time. You might also want to fix getDataLength() which is broken. (Apparently it is or would be called from SimpleDataObjectStore.java, but since many objects don't give accurate values, SDOS uses a different method). -- Ed Huff
--- StandardNodeEstimator.java.~1.3.~ 2003-09-30 00:23:36.000000000 -0400
+++ StandardNodeEstimator.java 2003-09-30 19:38:58.000000000 -0400
@@ -220,7 +220,7 @@
rpDNF.report(0.0);
// transferFailed is a peer event to dataNotFound, transferSucceeded
// and searchFailed
- rtTransferFailed.report(size);
+ rtTransferFailed.report(time);
Core.logger.log(this, "Transfer failed in "+time+"ms ("+
size+" bytes) on "+ref, new
Exception("debug"),
Logger.DEBUG);
@@ -264,11 +264,16 @@
public int getDataLength() {
return rpConnectFailed.getDataLength() +
-// rpQueryRejected.getDataLength() +
rpTransferFailed.getDataLength() +
- rpSearchFailed.getDataLength() + rpDNF.getDataLength() +
- rtConnectFailed.getDataLength() + rtConnected.getDataLength() +
-// rtQueryRejected.getDataLength() +
rtTransferFailed.getDataLength() +
- rtSearchFailed.getDataLength() +
etSuccessSearch.getDataLength() +
+// rpQueryRejected.getDataLength() +
+ rpTransferFailed.getDataLength() +
+ rpSearchFailed.getDataLength() +
+ rpDNF.getDataLength() +
+ rtConnectFailed.getDataLength() +
+ rtConnected.getDataLength() +
+// rtQueryRejected.getDataLength() +
+ rtTransferFailed.getDataLength() +
+ rtSearchFailed.getDataLength() +
+ etSuccessSearch.getDataLength() +
etTransferRate.getDataLength() +
epDNFGivenConnectionAndNotRejectedOrSearchFailed.getDataLength() +
etDNF.getDataLength();
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Devl mailing list [EMAIL PROTECTED] http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/devl
