On Tuesday 14 April 2009 20:24:08 dconr...@freenetproject.org wrote: > Author: dconrado > Date: 2009-04-14 19:24:07 +0000 (Tue, 14 Apr 2009) > New Revision: 26798 > > Modified: > trunk/freenet/src/freenet/clients/http/ConnectionsToadlet.java > Log: > Added red color into infobox Confirm external link.
Some comments below, please read. > > > Modified: trunk/freenet/src/freenet/clients/http/ConnectionsToadlet.java > =================================================================== > --- trunk/freenet/src/freenet/clients/http/ConnectionsToadlet.java 2009-04-14 19:23:40 UTC (rev 26797) > +++ trunk/freenet/src/freenet/clients/http/ConnectionsToadlet.java 2009-04-14 19:24:07 UTC (rev 26798) > @@ -117,6 +117,10 @@ > long total1 = firstNode.getTotalInputBytes()+firstNode.getTotalOutputBytes(); > long total2 = secondNode.getTotalInputBytes()+secondNode.getTotalOutputBytes(); > return compareLongs(total1, total2); > + }else if(sortBy.equals("total_traffic_since_restart")){ > + long total1 = firstNode.getTotalInputBytes()+firstNode.getTotalInputSinceSource(); > + long total2 = secondNode.getTotalInputBytes()+secondNode.getTotalOutputSinceSource(); You are not consistent here. input + input vs input + output ??? > + return compareLongs(total1, total2); > }else if(sortBy.equals("selection_percentage")){ > return > Double.compare(firstNode.getSelectionRate(), secondNode.getSelectionRate()); > }else if(sortBy.equals("time_delta")){ > @@ -402,6 +406,7 @@ > > peerTableHeaderRow.addChild("th").addChild("a", "href", sortString(isReversed, "time_routable")).addChild("#", "%\u00a0Time Routable"); > > peerTableHeaderRow.addChild("th").addChild("a", "href", sortString(isReversed, "selection_percentage")).addChild("#", "%\u00a0Selection"); > > peerTableHeaderRow.addChild("th").addChild("a", "href", sortString(isReversed, "total_traffic")).addChild("#", "Total\u00a0Traffic\u00a0 (in/out/resent)"); > + > peerTableHeaderRow.addChild("th").addChild("a", "href", sortString(isReversed, "total_traffic_since_restart")).addChild("#", "Total\u00a0Traffic\u00a0 (in/out) since restart"); That's the column header, where is the actual column data? > peerTableHeaderRow.addChild("th", > "Congestion\u00a0Control"); > > peerTableHeaderRow.addChild("th").addChild("a", "href", sortString(isReversed, "time_delta")).addChild("#", "Time\u00a0Delta"); > > peerTableHeaderRow.addChild("th").addChild("a", "href", sortString(isReversed, "uptime")).addChild("#", "Reported\u00a0Uptime");
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Devl mailing list Devl@freenetproject.org http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl