On Nov 23, 2012 4:09 PM, "Matthew Toseland" <[email protected]> wrote: > > On Friday 23 Nov 2012 20:47:24 Simon Vocella wrote: > > Hi all, > > > > i have more questions after one my little refactoring: > > > > - Why you don't user a log4j or similar project to log? > > There's a lot we could move to third party code, it's an ongoing process, e.g. we've started work on crypto recently. > > Re logging, we have fairly specialised requirements - even if we use a standard logging API, we'd probably need our own rotation/compression code, and we'd likely need other things too. E.g. we use logging quite a lot and have it all in if(class specific boolean) { ... }. The reason for this is generating the strings (and GCing them) can use a lot of CPU: it's vital that if logging is turned off for that class then it not do *anything*. There have been proposals to solve this in various less-ugly ways. Have a look at the devl archives if interested. I'd be interested to know if any of the standard logging solutions have an answer for this... Also, have a look at the config in advanced mode for logging to get an idea of why we'd need a custom logfile writer thread.
I just read about Blitz4j Netflix optimized version of log4j. Supposedly little to no performance impact under heavy logging due to asynchronous code. http://techblog.netflix.com/2012/11/announcing-bitz4j-scalable-logging.html Hosted on github here http://www.github.com/Netflix/blitz4j > > > > - The idea to use Apache Maven is worth with the guideline of Freenet? > > Security issues. Maven doesn't verify checksums/signatures when downloading dependencies. And also we have quite a few anonymous contributors, so downloading files during the build process is bad. > > > > - How can I test? There is a test suite? > > There is some junit coverage, the tests run during a normal build ("ant"). However, most high-level classes don't have unit tests. There are also some useful tools in freenet/node/simulator/ which run several nodes inside one JVM and have them test various functions. We need more tests. Most changes are tested by running a node ... > > > > Simon > > > > On Thu, Nov 22, 2012 at 9:46 AM, Simon Vocella <[email protected]> wrote: > > > > > Hi Matthew! Thanks for the answer! > > > > > > I already builded Freenet! Now I'm going to help in some way :) > > > > > > Simon > > > > > > > > > On Thu, Nov 22, 2012 at 12:46 AM, Matthew Toseland < > > > [email protected]> wrote: > > > > > >> On Monday 19 Nov 2012 07:55:22 Simon Vocella wrote: > > >> > Hi Steve, > > >> > > > >> > I compiled all from the source, but why bcprov.jar and freenet-ext.jar > > >> is > > >> > not in lib dir? license problem? > > >> > > > >> > And why junit.jar is not in lib dir too? > > >> > > >> It's bad form to put jars in git repositories, since it keeps a full > > >> history. So you have to download it by hand. The ant script will fetch it > > >> for you but that's off by default for security reasons, we have a few > > >> anonymous developers. > > >> > > >> Welcome aboard! Please ask any questions you need answering. You should > > >> be able to find bcprov and freenet-ext.jar, if only from an existing > > >> Freenet install, but otherwise download bcprov from bouncycastle.org(the 1.5 provider) and freenet-ext.jar from > > >> downloads.freenetproject.org/alpha/ > > >> > > > > > > > > > > _______________________________________________ > Devl mailing list > [email protected] > https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
_______________________________________________ Devl mailing list [email protected] https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
