-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/27/2013 08:59 PM, Matthew Toseland wrote:
> I don't have a big problem with this, as mockito appears to be
> packaged in debian. Best not to use a more recent version as
> installing java software can be problematic and insecure.
The exact version is surely debatable… I only used 1.9.5 because I had
it lying around on my disk. If you tell me which version Debian
currently packages I can try that one and if it works for my current
tests (so far it’s only one, anyway), that’s great.
> Having said that, much of fred doesn't need mockups. How many of
> our tests actually need a Node?
Looking at the serious mess that most of Fred’s code is I’m surprised
that so far you have been able to write tests at all without mocking
anything. The bookmark manager e.g. needs a NodeClientCore, a
USKManager, a UserAlertManager, and a Ticker, if I really wanted to
test it all.
>> Any opinions? (And: how exactly would we treat that? Simply add
>> it in build.properties and if somebody wants to run the test they
>> have to get it themselves?)
> Possibly, or make it optional?
Is JUnit optional for testing? I don’t think so, and it shouldn’t be.
Neither should Mockito be should we decide to use it. Running only
half of the tests because you’re missing a lib is stupid at best,
dangerous at worst.
Greetings,
David
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlH0TjAACgkQsh8Hgp5TwkOwyQCgpCJiP0qOiE8GRQllec4NeIPX
1acAn2la7f41S1dtavL3wOVAGaok/EBk
=gZq/
-----END PGP SIGNATURE-----
_______________________________________________
Devl mailing list
Devl@freenetproject.org
https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
