Le 08/05/2014 18:41, Steve Dougherty a écrit : > On 05/07/2014 06:55 AM, Rom. wrote: >> Hello Steve. >> >> Le 07/05/2014 07:48, Steve Dougherty a écrit : >>> I've updated romnGit's InnoSetup installer to use AHK_L so that the >>> executables still work when Freenet is installed to a path with Unicode >>> characters. [0] The wininstaller release script is updated to build and >>> sign it. [1] >> Nice to see some progress ! >>> Please test! >> https://downloads.freenetproject.org/FreenetInstaller-1461-innosetup-testing.exe >> The installer works well but i have a little glitch with the new AHK_L >> systray. >> https://lut.im/74lk5Fpn/NB6ikKHw . > Any ideas on how I can reproduce that problem? Compiled with AHK_L on my side : same issue but I think i have found the source. In the \AutoHotKey_files\ahk_sources\include_translator\Include_Translator.ahk , line 107: //// return UTF82Ansi(_TranslatedTextArray%A_Index%)
into return _TranslatedTextArray%A_Index% //// solve the problem. > >>> The uninstaller behavior isn't too intelligent - it just removes the >>> directory - but that's not a regression. Perhaps it should try to shut >>> down Freenet first, and remove directories and files more carefully? >> It's not that the uninstaller isn't intelligent: It just does what we >> configure it to do :) >> Yes, it should first try to shut down Freenet but unfortunately it's not >> a straightforward due to the mix of how Freenet "can" be shut down + the >> systray thing. >> See: https://bugs.freenetproject.org/view.php?id=5991 . >> Currently, i have worked very very quickly on this topic and just have >> an Exe which shutdown Freenet over FCP. (no more) >> >> About the careful removing of files/folders: it can be configured. > Yup. > >>> Having "Launch Freenet" checked when completing the installer does not >>> seem to open the setup page. One must fish out the tray icon and click >>> on it. >> You are right. That should be implemented (which is in the AHK installer) >>> Speaking of the tray icon, it should support changing which browser it >>> launches. It's debatable whether it's preferable at this point to >>> continue tweaking the tray app or just rewrite it altogether to avoid >>> antivirus detection problems. I'd be up for trying to make something >>> with WPF. Is a .NET dependency acceptable? >> Yes. I agree about the rewriting of the systray app. The only reason i >> haven't proposed and ported parts of the code from my personal project >> (FreenetForTraveler http://romngit.bitbucket.org/freenetfortraveler/) is >> due to the fact that the current version of Free Pascal doesn't come >> with full support of unicode. >> (http://wiki.freepascal.org/FPC_Unicode_support). >> >> I have also tried with python. I think it can be done, but this is (at >> least for me), a more long way to go. (python learning + creation of a >> working standalone exe for windows). >> >> If by WPF you mean Windows Presentation Foundation , i don't know it. > I do mean Windows Presentation Foundation. I've used it so if need be I > can write a tray app with WPF. I don't know WPF enough for helping you but does the systray app will be easily maintainable by other contributors if needed ? > I see you've updated your repo - should I have made a pull request? It's > harder to follow changes when they are copy-pasted from my version and > recommitted. Yes, sorry. I still try to figured out how to correctly use the merge functionality of git. > As far as opening the page [0] I wonder if it would work better to have > a command-line switch one can pass to the launcher to open the browser. That's a solution too. For the first start the systray app is launched with the switch "/welcome" ..\AutoHotKey_files\ahk_sources\freenettray\FreenetTray.ahk , line 76 > > [0] https://bugs.freenetproject.org/view.php?id=5862#c10447 > > > > _______________________________________________ > Devl mailing list > [email protected] > https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl _______________________________________________ Devl mailing list [email protected] https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
