-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > > I can't see why flushing a whole block after the trailing field name would be > absolutely necessary. You have to do it if you reach EndMessage, but when you > have a trailing field, it should start writing right away, so a flush should > not be necessary AFAIK. I tried this, but it didn't work. God only knows why. Its probably moot if we go with the modified CFB (which just makes me far happier than the current situation) > > > Code is commited, if you want a look. The problem (2) is in RawMessage, > > writeMessage(). Look for appropriate comments. > > This is what I meant. Because you have a flush() that means something else in > the PrintWriter, it will then calling it on the underlying stream assuming > it can be used their for the same purposes. This is why I wanted to use a > different method, blockFlush() or something, for flushing out a block. It is > not the same as flushing the buffer on an OutputStream, which is used to clear > the buffers whenever one ends the use of a FilterOutputStream.
True, but it wouldn't have solved anything. > Also, I think you forgot the SymmetricCipherListener in your commit. We can > discuss where to place the cipher finally, it would either be within the > Connection object (what I refer to as the carrier protocol), or within the > RawMessage (the Freenet protocol), or somewhere in between. It is important > that if we place it somewhere in between, we make it as pluggable as the other > parts (I want to make a NoCipher version for the testbed in that case). Having it in the Listener/Connection structure seems to be problematic. It doesn't allow us to flexibly change the connections.. I'm probably going to back out my changes and try the RawMessage approach. We want to plug it in where it doesn't need to know anything at all about *anything* except the actual streams. Currently its having to sidestep around addresses, protocols, and connections, which makes me ill. scott -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.1 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE5ECwDpXyM95IyRhURAp9NAKDFUUTEc1XQKYbe91XugxnuLxeSnQCeOj1k iuwiDfXikX/vqfq2+tPSI+o= =3Oek -----END PGP SIGNATURE----- _______________________________________________ Freenet-dev mailing list Freenet-dev at lists.sourceforge.net http://lists.sourceforge.net/mailman/listinfo/freenet-dev
