Hi Mr. Bad (or who's primarily responsible for fproxy?),

when you say "retrieve anyway" on the anonimity filter warning page, fproxy 
seriously damages the key uri by URLEncoding it.

Encoding spaces and other nasty characters is a good idea of course. Slashes, 
on the other hand, are replaced by %2F which messes up all relative links in 
freesite pages. I get quite a few complaints about people unable to access the 
freegle applet because of this.

These are the offending lines (HttpHandlerServlet 334-336):

  String encKey = java.net.URLEncoder.encode(key);
  String forceKey = makeForceKey();
  pw.println("<p><a href=\"/" + encKey + "?force=" + forceKey + "\">Retrieve 
anyway</A>, see the <a href=\"/" + encKey + "?mime=text/plain\">source</A> or 
<A HREF=\"/\">return</A> to gateway page");

It would suffice to convert %2F back to / after the encoding - or write your 
own URLEncoder... do you want me to supply a patch?

-Stefan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20010602/55b2bd70/attachment.html>

Reply via email to