On Sunday 20 January 2002 15:01, you wrote: > On Sun, Jan 20, 2002 at 02:54:08PM -0500, Gianni Johansson wrote: > > On Saturday 12 January 2002 23:20, you wrote: > > > Should I be worried or look for in my log for something that might be > > > helpful? > > > > > > How many can leak before I should restart my node? > > > > > > Ed > > > > Oskar, Tavin: > > Can I safely ignore these? > > I don't know. I thought it was synchronized so that that could not come > up unless CHs were actually being left around when they closed, but I > have no idea what has been done to it since.
Oskar: I think that the "ConnectionHandlers ARE LEAKING! " messages are spurious. Remember a good while back, you and thelema tracked down a deadlock that was cause by calling OCM.remove() while holding sendlock in ConnectionHandler. I changed the ConnectionHandler so that OCM.remove() isn't called until sendlock is released. This means that there is a short interval where closed ConnectionHandlers are still in the OCMs list. My changes to ConnectionHandler didn't elicit any howls of protest at the time. I think that they are ok. Do you buy this story? If so, I will remove the warning messages. --gj see: http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/freenet/freenet/src/freenet/ConnectionHandler.java?rev=HEAD&content-type=text/plain http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/freenet/freenet/src/freenet/OpenConnectionManager.java?rev=HEAD&content-type=text/plain -- Freesites (0.4) freenet:SSK at npfV5XQijFkF6sXZvuO0o~kG4wEPAgM/homepage// _______________________________________________ Devl mailing list Devl at freenetproject.org http://lists.freenetproject.org/mailman/listinfo/devl
