Summary: "freenet.client.cli.Main --skipDS put" does not work. Please
fix.
Detail: PutCommand.java is not checking the "skipDS" parameter. That's
easy enough to fix:
Index: PutCommand.java
===================================================================
RCS file: /cvsroot/freenet/freenet/src/freenet/client/cli/PutCommand.java,v
retrieving revision 1.4.4.4
diff -u -r1.4.4.4 PutCommand.java
--- PutCommand.java 7 Mar 2003 23:27:08 -0000 1.4.4.4
+++ PutCommand.java 30 Mar 2003 03:22:29 -0000
@@ -126,6 +126,7 @@
ms.setSplitFileRetryHtlIncrement(0); // Doesn't make sense for
inserts.
ms.setSplitFileRetries(p.getInt("retries"));
ms.setSplitFileThreads(p.getInt("threads"));
+ ms.setNonLocal(p.getBoolean("skipDS"));
// REDFLAG: fix so null works
String algoName = (p.getParam("algoName") != null) ?
p.getParam("algoName") :
"OnionFEC_a_1_2";
*But*... the flag that's set by setNonLocal() is not being checked
by the insertion code. The *fetching* code (NewInternalGet()) has
a check for ft.req.getNonLocal() but there is no similar check in
the insertion code (NewInternalPut()).
jrand0m and I were discussing this in IRC, and we couldn't decide
how it should be fixed.
22:02 iip> <jrand0m> it isn't in the code. just copy that block if
(ft.req.getNonLocal()) { ... } to NewInternalPut right before
ClientEvent evt = ft.state(Request.PREPARED); (or, to start, put
the debug statement there)
22:03 iip> <jrand0m> NewInternalGet isn't called when you're doing put requests
22:04 iip> <jrand0m> btw, I take that back about copying that block of code
22:04 greycat> why/
22:07 iip> <jrand0m> I'm not sure if it goes there or if it goes at the end
of the received(Node n, Message msg) {} method, and I'm hesitant
to delete data before its no longer needed
Rumor has it that inserts through FCP actually do work with
RemoveLocalKey=true but I have not yet confirmed or failed to confirm
this.
--
Greg Wooledge | "Truth belongs to everybody."
greg at wooledge.org | - The Red Hot Chili Peppers
http://wooledge.org/~greg/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20030329/1f26452a/attachment.pgp>
