Joel, thanks for this - could you put it into the bug tracker if you  
haven't already?  http://bugs.freenetproject.org/

Ian.

On 30 Apr 2006, at 09:31, Joel Salomon wrote:

> Bug report.
>
> On the "Queued Requests" page of recent builds of 0.7, the success of
> uploads (and presumably requests, but I don't have any downloads to
> test against) is reported as a frraction, but the number is reported
> as a percent; for example, an upload that is half done (FUQID reports
> 50%) is listed as being 0.5% by FProxy.
>
> The code in trunk/freenet/src/freenet/clients/http/QueueToadlet.java
> does have the lines
>       private void writeSuccessFractionCell(ClientRequest p,  
> StringBuffer buf) {
>               double frac = p.getSuccessFraction();
>               if(frac < 0) {
>                       buf.append("<td>UNKNOWN</td>\n");
>               } else {
>                       buf.append("<td>");
>                       buf.append(frac * 100);
>                       buf.append("%</td>\n");
>               }
>       }
> but somehow frac * 100 is being reported as frac.  I'm not sure where
> the code implementing ClientRequest.getSuccessFraction() is, so I'm
> not submitting a patch.  (Also, I'm not sure how to submit one if I
> created it.)
>
> --Joel
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl


Reply via email to