Very nice. One minor quibble though. Ambiguity is bad in code (and law); use brackets to prevent it.
On Thu, May 18, 2006 at 09:37:42AM +0000, nextgens at freenetproject.org wrote: > Author: nextgens > Date: 2006-05-18 09:37:33 +0000 (Thu, 18 May 2006) > New Revision: 8757 > > Modified: > trunk/freenet/src/freenet/node/Node.java > trunk/freenet/src/freenet/node/TestnetHandler.java > Log: > Should fix https://bugs.freenetproject.org/view.php?id=227 > > * Testnet port is now updatable on the fly > > + public void rebind(int port){ > + synchronized(server) { > + try{ ************************************************************************** > + if(!server.isClosed()&&server.isBound()) ************************************************************************** > + server.close(); > + this.testnetPort=port; > + }catch( IOException e){ > + Logger.error(this, "Error while stopping the > testnet handler."); > + System.exit(Node.EXIT_TESTNET_FAILED); > + return; > + } > + } > + } > + > @@ -197,31 +217,20 @@ -- Matthew J Toseland - toad at amphibian.dyndns.org Freenet Project Official Codemonkey - http://freenetproject.org/ ICTHUS - Nothing is impossible. Our Boss says so. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20060518/5c397853/attachment.pgp>
