On Tuesday 28 August 2007 09:46, Alberto Bacchelli wrote: > There is a lot of not referenced methods in freenet.crypt.Util class: > > fillByteArrayFromInts(int[] ints, byte[] bytes); > fillByteArrayFromLongs(long[] ints, byte[] bytes); > fillIntArrayFromBytes(byte[] bytes, int[] ints); > fillLongArrayFromBytes(byte[] bytes, long[] longs); > BigInteger generateLargeRandom(int lowerBound,int upperBound,Random r); > hashString(Digest d, String s); > byteArrayEqual(byte[] a, byte[] b, int offset, int length); > getCipherByName(String name, int keySize); > getDigestByName(String name); > log2(long n); > > IMHO it would be better to completely remove them, since they could > possibly have bugs and probably nobody will use them (do devs even know > their existence?).
We should remove them yes. We can bring them back later if needed. If I or anyone else sees a Really Useful Method being removed in a commit, we can put them back and use them. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20070831/b3696a81/attachment.pgp>
