On 2/15/07, Matthew Toseland <toad at amphibian.dyndns.org> wrote:
> My concern with this is that we will want to modify things other than
> the obvious priority class etc. So the message will get bigger and
> bigger and bigger, and eventually be as big as Persistent* was in the
> first place. I dunno if this is a serious problem though.
The Modified message is always smaller than the PersistentBlah
message. Only *changed* fields are sent to the clients, its unlikely
that clients often change more than one of the fields, hence I think
the messages will always be small.
>
> On Tue, Feb 13, 2007 at 04:35:30PM +0000, bback at freenetproject.org wrote:
> > Author: bback
> > Date: 2007-02-13 16:35:29 +0000 (Tue, 13 Feb 2007)
> > New Revision: 11766
> >
> > Modified:
> > trunk/freenet/src/freenet/node/fcp/ClientRequest.java
> > trunk/freenet/src/freenet/node/fcp/ModifyPersistentRequest.java
> > Log:
> > corrected methodname
> >
> > Modified: trunk/freenet/src/freenet/node/fcp/ClientRequest.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/node/fcp/ClientRequest.java 2007-02-12
> > 22:19:30 UTC (rev 11765)
> > +++ trunk/freenet/src/freenet/node/fcp/ClientRequest.java 2007-02-13
> > 16:35:29 UTC (rev 11766)
> > @@ -307,7 +307,7 @@
> > * Called after a ModifyPersistentRequest.
> > * Sends a PersistentRequestModified message to clients if any value
> > changed.
> > */
> > - public void requestWasModified(String newClientToken, short
> > newPriorityClass) {
> > + public void modifyRequest(String newClientToken, short
> > newPriorityClass) {
> >
> > boolean clientTokenChanged = false;
> > boolean priorityClassChanged = false;
> >
> > Modified: trunk/freenet/src/freenet/node/fcp/ModifyPersistentRequest.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/node/fcp/ModifyPersistentRequest.java
> > 2007-02-12 22:19:30 UTC (rev 11765)
> > +++ trunk/freenet/src/freenet/node/fcp/ModifyPersistentRequest.java
> > 2007-02-13 16:35:29 UTC (rev 11766)
> > @@ -73,6 +73,6 @@
> > return;
> > }
> >
> > - req.requestWasModified(clientToken, priorityClass);
> > + req.modifyRequest(clientToken, priorityClass);
> > }
> > }
> >
> > _______________________________________________
> > cvs mailing list
> > cvs at freenetproject.org
> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> >
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFF07lxA9rUluQ9pFARAu0aAJ4uMVNVZ2IYSMrdD9tOPxkTnTpyMQCeLvAZ
> fQzXoIjfXYkiZ+v3ytKthow=
> =M2Sq
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
