On Sun, Aug 24, 2008 at 6:13 AM, Matthew Toseland
<toad at amphibian.dyndns.org> wrote:
> On Wednesday 20 August 2008 09:31, j16sdiz at freenetproject.org wrote:
>> Author: j16sdiz
>> Date: 2008-08-20 08:31:01 +0000 (Wed, 20 Aug 2008)
>> New Revision: 22049
>>
>> Modified:
>>
> branches/saltedhashstore/freenet/src/freenet/store/saltedhash/SaltedHashFreenetStore.java
>> Log:
>> fix 2516: probablyInStore() for SaltedHashFreenetStore
>>
>> Modified:
> branches/saltedhashstore/freenet/src/freenet/store/saltedhash/SaltedHashFreenetStore.java
>> ===================================================================
>> ---
> branches/saltedhashstore/freenet/src/freenet/store/saltedhash/SaltedHashFreenetStore.java
> 2008-08-20 08:30:40 UTC (rev 22048)
>> +++
> branches/saltedhashstore/freenet/src/freenet/store/saltedhash/SaltedHashFreenetStore.java
> 2008-08-20 08:31:01 UTC (rev 22049)
>> @@ -1671,4 +1671,15 @@
>> e.printStackTrace();
>> }
>> }
>> +
>> + public boolean probablyInStore(byte[] routingKey) {
>> + configLock.readLock().lock();
>> + try {
>> + if (!checkBloom)
>> + return false;
>
> No, it has to err on the side of caution. If it doesn't know, it must return
> true.
this is fixed in r22050.
>
>> + return
> bloomFilter.checkFilter(cipherManager.getDigestedKey(routingKey));
>> + } finally {
>> + configLock.readLock().unlock();
>> + }
>> + }
>> }
>
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
