* Matthew Toseland <toad at amphibian.dyndns.org> [2008-08-25 22:15:35]:
> On Monday 25 August 2008 17:37, nextgens at freenetproject.org wrote:
> > Author: nextgens
> > Date: 2008-08-25 16:37:44 +0000 (Mon, 25 Aug 2008)
> > New Revision: 22138
> >
> > Modified:
> > trunk/freenet/src/freenet/support/io/TempBucketFactory.java
> > Log:
> > TempBucketFactory: really fix the issue with InputStreams; we need to
> reimplement everything!
> >
> > Modified: trunk/freenet/src/freenet/support/io/TempBucketFactory.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/support/io/TempBucketFactory.java
> > 2008-08-25
> 16:31:57 UTC (rev 22137)
> > +++ trunk/freenet/src/freenet/support/io/TempBucketFactory.java
> > 2008-08-25
> 16:37:44 UTC (rev 22138)
> > @@ -222,6 +222,54 @@
> > }
> >
> > @Override
> > + public long skip(long n) throws IOException {
> > + synchronized(currentBucket) {
> > + _maybeResetInputStream();
> > + return is.skip(n);
> > + }
> > + }
>
> You need to increment index here.
Right, done in r22155
> > + @Override
> > + public void reset() throws IOException {
> > + synchronized(currentBucket) {
> > + _maybeResetInputStream();
> > + is.reset();
> > + }
> > + }
>
> You need to reset index here (presumably store it in mark(), subject to
> isMarkSupported() and the mark limit - and don't assume the caller calls
> isMarkSupported() either!).
Done in r22156... But I assumed that the undelying bucket will throw if
we are above the mark limit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080825/cad7caa9/attachment.pgp>
