On Sunday 21 December 2008 13:12, Daniel Cheng wrote: > Some error is occuring on my node.. > :: Segment finishing but didn't tell us! > freenet.client.async.SplitFileFetcherSubSegmenet.... > > maybe related to r24669.... or maybe not. > I am not sure.
Are there any discernible symptoms? I'm hoping to merge db4o in the coming weeks, so I'm not keen to spend time debugging trunk's client layer... > > On Sun, Dec 21, 2008 at 9:05 PM, <j16sdiz at freenetproject.org> wrote: > > Author: j16sdiz > > Date: 2008-12-21 13:05:24 +0000 (Sun, 21 Dec 2008) > > New Revision: 24705 > > > > Modified: > > trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java > > Log: > > Revert r24669 "try to fix a ClientGetter leak on getter.cancel()" > > what's broken? > > > > Modified: trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java > > =================================================================== > > --- trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java > > 2008-12-21 12:44:04 UTC (rev 24704) > > +++ trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java > > 2008-12-21 13:05:24 UTC (rev 24705) > > @@ -99,15 +99,7 @@ > > */ > > @Override > > public Object[] allKeys() { > > - // this is not enough for unregistering > > - // return segment.getKeyNumbersAtRetryLevel(retryCount); > > - > > - int keyCount = segment.dataKeys.length + segment.checkKeys.length; > > - Object[] ret = new Object[keyCount]; > > - for (int i = 0; i < keyCount; i++) > > - ret[i] = i; > > - > > - return ret; > > + return segment.getKeyNumbersAtRetryLevel(retryCount); > > } > > > > /** > > > > _______________________________________________ > > cvs mailing list > > cvs at freenetproject.org > > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs > > > _______________________________________________ > Devl mailing list > Devl at freenetproject.org > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl > > -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 827 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20081222/f3f7d456/attachment.pgp>