On Tuesday 29 July 2008 02:26, Daniel Cheng wrote:
> On Tue, Jul 29, 2008 at 7:43 AM, <toad at freenetproject.org> wrote:
> > Author: toad
> > Date: 2008-07-28 23:43:50 +0000 (Mon, 28 Jul 2008)
> > New Revision: 21459
> >
> > Modified:
> > branches/db4o/freenet/src/freenet/client/async/InsertCompressor.java
> > branches/db4o/freenet/src/freenet/client/async/SingleFileInserter.java
> > Log:
> > Really fix Cooo's NPEs i think
> >
> > Modified:
branches/db4o/freenet/src/freenet/client/async/InsertCompressor.java
> > ===================================================================
> > --- branches/db4o/freenet/src/freenet/client/async/InsertCompressor.java
> >
2008-07-28 23:32:14 UTC (rev 21458)
> > +++ branches/db4o/freenet/src/freenet/client/async/InsertCompressor.java
> >
2008-07-28 23:43:50 UTC (rev 21459)
> > @@ -55,6 +55,15 @@
> > container.activate(inserter, 1);
> > container.activate(origData, 1);
> > }
> > + if(origData == null) {
> > + if(inserter == null || inserter.cancelled()) {
> > + container.delete(this);
> > + return; // Inserter was cancelled, we
weren't told.
>
> Why weren't told? Does this means bugs somewhere else?
> Does this affect trunk?
A race condition - we don't tell the InsertCompressor on cancelling at the
moment, so if the compression didn't finish before we shut down, this is
possible. (If it did finish, the InsertCompressor will be deleted in any
case).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080729/efab5c41/attachment.pgp>
