On Tuesday 06 May 2008 02:58, Daniel Cheng wrote: > On Tue, May 6, 2008 at 8:47 AM, Matthew Toseland > <toad at amphibian.dyndns.org> wrote: > > On Monday 05 May 2008 14:01, j16sdiz at freenetproject.org wrote: > > > Author: j16sdiz > > > Date: 2008-05-05 13:01:55 +0000 (Mon, 05 May 2008) > > > New Revision: 19759 > > > > > > Modified: > > > trunk/freenet/src/freenet/support/NumberedItemComparator.java > > > Log: > > > use assert > > > > Base must be odd?? Explain? > > > > Also the class should be package private if you're going to make this sort of > > assumptions... > > > > I didn't make up that comment, I just moved the comment from below. > Can not understand that either, that's why I added an "assert".
Well it probably makes more sense to implement the correct behaviour and remove the assert. > > > > + // REDFLAG: base must be odd, so we never get == > [...] > > > return -1; // i2>i1 > > > - // REDFLAG: base must be odd, so we never get == -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20080506/5473807f/attachment.pgp>
