On Sat, May 24, 2008 at 2:33 AM, Matthew Toseland
<toad at amphibian.dyndns.org> wrote:
> On Thursday 22 May 2008 11:31, j16sdiz at freenetproject.org wrote:
>> Author: j16sdiz
>> Date: 2008-05-22 10:31:44 +0000 (Thu, 22 May 2008)
>> New Revision: 20027
>>
>> Modified:
>>
> branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
>> Log:
>> Limit oldItems file size
>>
>>
>> Modified:
> branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
>> ===================================================================
>> ---
> branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
> 2008-05-22 10:24:30 UTC (rev 20026)
>> +++
> branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
> 2008-05-22 10:31:44 UTC (rev 20027)
>> @@ -976,7 +976,7 @@
>> }
>> }
>>
>> - if (queueItem) {
>> + if (queueItem &&
>> oldItemsFC.position() < 0x10000000) { // Limit to
> 256MiB
>
> Wouldn't it be better to make it some fixed fraction of the total size or
> perhaps of the limit?
sure.
but then we have to ask: what is the right limit?
I am not going to tune these kind of stuff at this stage.
>
>> if (logDEBUG)
>>
>> Logger.debug(this, "old entry " +
> HexUtil.bytesToHex(entry.getDigestedRoutingKey())
>> + "
>> queued");
>
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
