On Thu, May 1, 2008 at 4:50 AM, Matthew Toseland <toad at amphibian.dyndns.org> wrote: > On Wednesday 30 April 2008 19:34, Matthew Toseland wrote: > > On Saturday 26 April 2008 04:57, j16sdiz at freenetproject.org wrote: > > > Author: j16sdiz > > > Date: 2008-04-26 03:57:34 +0000 (Sat, 26 Apr 2008) > > > New Revision: 19567 > > > > > > Modified: > > > trunk/freenet/src/freenet/store/BerkeleyDBFreenetStore.java > > > Log: > > > use FileChannel.read()/write() in BDBFS > > > > > All good stuff, however: > > - Don't use allocateDirect() unless you plan to keep the returned > ByteBuffer > > around for a long time. They are immobile and therefore hard to garbage > > collect. > > Sorry... I should really queue my replies until I reach the end of the commit > log. :| > > > > - ClosedChannelException, AsynchronousCloseException and > > ClosedByInterruptException should be caught and cause a silent failure for > a > > smooth shutdown. > > > This is however still valid. >
fixed in r19641 ClosedChannelException is the super class of other two.
