> > There is no FIXME in IdentityFetcher.java, hence my question.
Sorry I commited the wrong file. I just added the FIXME. > >> But it's not a really big problem to add it I guess. I > will probably > >> do it when I add synchronization to FMS if it has not been > done then > >> yet. > > > > Transactions may be an issue too. However, if every operation > > initiated by a client starts fresh and then does a commit, > and there > > is a BFL protecting everything, it should work acceptably. Multiple > > database operations on different threads might be a problem. > > There are only two threads : > - The plugin itself that perform every requests and client > interaction. > - The IdentityInserter. Its only database operation is to > update OwnIdentities insert date. Even only two threads can cause serious problems if they try to access the same data at the same time :) And as soon as there is FMS or any other WoT it will continously do very much reading of identites which will definitely cause problems if there is no synchronization.
