On Thursday 04 September 2008 23:48, Daniel Cheng wrote:
> On Fri, Sep 5, 2008 at 12:56 AM, <toad at freenetproject.org> wrote:
> > Author: toad
> > Date: 2008-09-04 16:56:06 +0000 (Thu, 04 Sep 2008)
> > New Revision: 22422
> >
> > Modified:
> > trunk/freenet/src/freenet/support/Fields.java
> > Log:
> > bytesToInts was broken, ouch!
> >
>
> This would break backward-compatibility.
>
> 0) MT(byte[] seed) use bytesToInts to initialize the seed
Which means that MT would repeat? Or merely that it has far less initial
entropy than it should have?
> 1) CHK@ padding use MT(digest) to pad
Acceptable collateral damage, in fact it's an important bugfix.
> 2) BloomFilter use MT(key) for the hashes
Ouch. Well, it's unavoidable. Do what you have to do...
>
>
>
> > Modified: trunk/freenet/src/freenet/support/Fields.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/support/Fields.java 2008-09-04
16:56:04 UTC (rev 22421)
> > +++ trunk/freenet/src/freenet/support/Fields.java 2008-09-04
16:56:06 UTC (rev 22422)
> > @@ -538,7 +538,7 @@
> > for(int i = 0; i < ints.length; i++) {
> > int x = 0;
> > for(int j = 3; j >= 0; j--) {
> > - int y = (buf[j + offset] & 0xff);
> > + int y = (buf[j + offset + i * 4] & 0xff);
> > x = (x << 8) | y;
> > }
> > ints[i] = x;
> >
> > _______________________________________________
> > cvs mailing list
> > cvs at freenetproject.org
> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> >
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080905/1a9ebdfb/attachment.pgp>
