On Friday 03 April 2009 09:50:34 Daniel Cheng wrote:
> On Fri, Apr 3, 2009 at 7:59 AM, <toad at freenetproject.org> wrote:
> > Author: toad
> > Date: 2009-04-02 23:59:42 +0000 (Thu, 02 Apr 2009)
> > New Revision: 26397
> >
> > Modified:
> > ? trunk/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java
> > Log:
> > Better priority/retrycount comparison
> >
> >
> > Modified:
trunk/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java
> > ===================================================================
> > ---
trunk/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java ? ?
?2009-04-02
23:54:43 UTC (rev 26396)
> > +++
trunk/freenet/src/freenet/client/async/ClientRequestSchedulerCore.java ? ?
?2009-04-02
23:59:42 UTC (rev 26397)
> > @@ -508,8 +508,10 @@
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?Logger.minor(this,
> "Ignoring
cancelled recently succeeded item "+altReq);
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?altReq = null;
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?}
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if(altReq != null &&
altReq.getPriorityClass(container) <= choosenPriorityClass &&
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?
fixRetryCount(altReq.getRetryCount()) <= chosenTracker.getNumber()
&& !altReq.isEmpty(container) && altReq != req) {
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? int prio =
altReq.getPriorityClass(container);
>
> altReq maybe null.
> This is throwing NPE
Doh, thanks for fixing!
>
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if(altReq != null &&
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20090406/3567a50e/attachment.pgp>
