On Saturday 21 February 2009 13:52:40 Florent Daigni?re wrote: > * Matthew Toseland <toad at amphibian.dyndns.org> [2009-02-21 13:41:12]: > > > On Tuesday 27 January 2009 15:13:38 nextgens at freenetproject.org wrote: > > > Author: nextgens > > > Date: 2009-01-27 15:13:37 +0000 (Tue, 27 Jan 2009) > > > New Revision: 25317 > > > > > > Modified: > > > trunk/freenet/src/freenet/node/NodeStats.java > > > Log: > > > cache the results for 60 secs > > > > IMHO this is over-optimisation. The only case in which we use this is > > rendering the statistics page in advanced mode. If the user wants detailed > > diagnostics, we should give them up to date and accurate figures. > > iirc that has a *significant* impact on "latency" of the whole node > because of locking contention...
Only if they load the stats page more often than every 60 seconds? > > Well, revert it if you don't like it :) > > NextGen$ > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20090221/20ece2ee/attachment.pgp>
