On Monday 22 December 2008 05:04, j16sdiz at freenetproject.org wrote: > Author: j16sdiz > Date: 2008-12-22 05:04:38 +0000 (Mon, 22 Dec 2008) > New Revision: 24722 > > Modified: > trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java > Log: > comment > > Modified: trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java > =================================================================== > --- trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java 2008-12-22 03:06:33 UTC (rev 24721) > +++ trunk/freenet/src/freenet/client/async/SplitFileFetcherSubSegment.java 2008-12-22 05:04:38 UTC (rev 24722) > @@ -99,6 +99,9 @@ > */ > @Override > public Object[] allKeys() { > + // j16sdiz (22-DEC-2008): > + // ClientRequestSchedular.removePendingKeys() call this to get > a list of request to be removed > + // FIXME ClientRequestSchedular.removePendingKeys() is leaking, > what's missing here? > return segment.getKeyNumbersAtRetryLevel(retryCount);
Most likely there is some path where the keys don't get removed? IMHO this is fixed in the db4o branch, which should merge in the relatively near future. > } -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 827 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20090110/5a271552/attachment.pgp>