A few notes on the commit:
+ } catch (MalformedURLException e) {
+ Logger.error(this, "Malformed URI in N2NTM Bookmark
Feed message");
+ } catch (IllegalBase64Exception e) {
- should return
+ description = encodedDescription == null ? null : new
String(Base64.decode(encodedDescription));
- why new String() ?
Subscribe/UnsubscribeFeed etc etc should eventually be documented on the wiki.
BookmarkFeedUserAlert: getTitle(), getText(), getShortText(), getHTMLText(),
all need l10n. Likewise DownloadFeedUserAlert.
UserAlertManager.register: do they need to run all in parallel? can't we push
the loop to a single job?
getAtom(): don't you want to include the # anchor to point to the specific
message?
Apart from the above, looks good...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20090702/8d20eebe/attachment.pgp>
