On Thursday 09 July 2009 23:23:22 Florent Daigni?re wrote: > commit 5eb705d855191cf87b1cfbbae46d968f1ddd7eb3 > Author: Matthew Toseland <toad at amphibian.dyndns.org> > Date: Fri Jul 3 19:57:12 2009 +0100 > > Sanity check for UPnP bandwidth autodetection > > > + int upstreamBWLimit = > bwIndicator.getUpstramMaxBitRate(); > + if(downstreamBWLimit > 0 && downstreamBWLimit < 65536 || > upstreamBWLimit > 0 && ups > + // These are kilobits, not bits, per second, > right? > + // Assume the router is buggy and don't > autoconfigure. > > ################################################################## > > Congratz, you broke working code! > > They are bits per second as specified by the specification. Hint: google > for UPnP_IGD_WANPPPConnection 1.0.pdf
It was reporting kilobits for one specific router. But I agree we need some extra brackets. Doh. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20090710/e1d8f109/attachment.pgp>
