[freenet-dev] 9645c37: Fix logging.

[Daniel Cheng]

Please don't do this.
Closer is for closing the streams _silently_.
(most often in the finally{} block when error have occurred already/expected)
If you want logging, you should call .close() directly.


commit 9645c379de05e4f884ac3c1e2ef616884232963c
Author: xor <xor at freenetproject.org>
Date:   Mon May 4 20:13:04 2009 +0200

    Fix logging.

diff --git a/src/freenet/support/io/Closer.java
b/src/freenet/support/io/Closer.java
index 1e7a532..6899e63 100644
--- a/src/freenet/support/io/Closer.java
+++ b/src/freenet/support/io/Closer.java
@@ -46,6 +46,7 @@ public class Closer {
                        try {
                                closable.close();
                        } catch (IOException e) {
+                               Logger.error(Closer.class, "Error
during close().", e);
                        }
                }
        }
@@ -59,7 +60,7 @@ public class Closer {
                        try {
                                bucket.free();
                        } catch(RuntimeException e) {
-                               Logger.error(bucket, "Error during free().");
+                               Logger.error(Closer.class, "Error
during free().", e);
                        }
                }
        }
@@ -75,6 +76,7 @@ public class Closer {
                        try {
                                zipFile.close();
                        } catch (IOException e) {
+                               Logger.error(Closer.class, "Error
during close().", e);
                        }
                }
        }