On Sat, May 30, 2009 at 6:59 PM, Matthew Toseland
<toad at amphibian.dyndns.org> wrote:
> On Saturday 30 May 2009 08:08:02 Daniel Cheng wrote:
>> On Sat, May 30, 2009 at 4:18 AM, Matthew Toseland
>> <toad at amphibian.dyndns.org> wrote:
>> > Current fred-staging contains sub-menu support, and some major changes to
>> > PageMaker, mostly supporting this. This has broken compatibility with most
>> > plugins, but sub-menu support *should* be very helpful for plugins. I have
>> > fixed most of them. Some have serious issues remaining:
>> >
>> > XMLSpider
>> > =======
>> >
>> > I have fixed XMLSpider and made it use Toadlet's, and given it a submenu
>> > of its own, however I am unable to test it properly as it gives database
>> > errors constantly, which I'm fairly sure are not the result of my changes.
>>
>> I have fixed them all.
>> They are the result of your changes --- ?toadlets have to set the
>> classloader. The original code did that. but your new code don't.
>
> I don't understand where this changed. Which commit?
The plugin http code ("src/freenet/pluginmanager/PluginManager.java",
line ~606) set the context classloader before calling
plugin.handleHTTPGet(), but your toadlet code don't do this.
This is fixed in XMLSpider 1112f38c25beb .
