Sorry, I saw no change on github at the time when I wrote this mail :)
On Thu, Nov 26, 2009 at 20:36, Artefact2 <artefact2 at gmail.com> wrote:
> Yeah, I did.
> What did you expect me to solve when I said "I'm on it" ? :D
>
> On Thu, Nov 26, 2009 at 8:14 PM, <bbackde at googlemail.com> wrote:
>>
>> Great. Will you also check the sort by nickname problem? Would be
>> nice, you implemented it, right?
>>
>> On Thu, Nov 26, 2009 at 19:48, Artefact2 <artefact2 at gmail.com> wrote:
>> >
>> >
>> > On Thu, Nov 26, 2009 at 7:39 PM, Artefact2 <artefact2 at gmail.com> wrote:
>> >>
>> >>
>> >> On Thu, Nov 26, 2009 at 6:18 PM, <bbackde at googlemail.com> wrote:
>> >>>
>> >>> Thanks for your review.
>> >>>
>> >>> I hope Artefact2 will address this one:
>> >>> > Testing:
>> >>> > Why does the color coding apply to 2 columns in some cases and 1
>> >>> > column
>> >>> > in others?
>> >>> >
>> >>> > Sort by doesn't work - it goes back to the page asking me to select
>> >>> > the
>> >>> > trust tree owner.
>> >>
>> >> I'm on it. I didn't test with multiple identities...
>> >> The color coding applies on the two columns when local trust is set,
>> >> and
>> >> one column when only derived
>> >> trust is availible ; exactly like FMS does.
>> >
>> > It works now.
>> >
>> >>
>> >>
>> >>>
>> >>> Xor will address this one:
>> >>> > - returning null is *significantly* faster, is this worthwhile? It
>> >>> > makes the code more consistent...
>> >>> > I don't see where "Also import introduction for already known
>> >>> > identities." is implemented.
>> >>>
>> >>> And I will address the l10n stuff.
>> >>>
>> >>> Is this ok guys?
>> >>>
>> >>> On Thu, Nov 26, 2009 at 18:06, Matthew Toseland
>> >>> <toad at amphibian.dyndns.org> wrote:
>> >>> > 15221314f54fe5d3fe2cf295a6b1e77824bde0d8
>> >>> > - returning null is *significantly* faster, is this worthwhile? It
>> >>> > makes the code more consistent...
>> >>> >
>> >>> > formatTimeDelta l10n:
>> >>> > Separating the hours and ago may not work well in some languages,
>> >>> > there
>> >>> > should just be one string, probably with substitution i.e.
>> >>> > "${number} hours
>> >>> > ago".
>> >>> >
>> >>> >
>> >>> > 41256004e28fe8bccfc9834bd71b0fe1953dfb39
>> >>> > I don't see where "Also import introduction for already known
>> >>> > identities." is implemented.
>> >>> >
>> >>> >
>> >>> > Check that Web of Trust menu title is correctly localised.
>> >>> >
>> >>> >
>> >>> > Testing:
>> >>> > Why does the color coding apply to 2 columns in some cases and 1
>> >>> > column
>> >>> > in others?
>> >>> >
>> >>> > Sort by doesn't work - it goes back to the page asking me to select
>> >>> > the
>> >>> > trust tree owner.
>> >>> >
>> >>> > Neither "select the trust tree owner" nor "web of trust" is
>> >>> > particularly newbie friendly, maybe we should change them, some
>> >>> > ideas have
>> >>> > come up for the latter.
>> >>> >
>> >>> > _______________________________________________
>> >>> > Wot mailing list
>> >>> > Wot at freenetproject.org
>> >>> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/wot
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> __________________________________________________
>> >>> GnuPG key: ? (0x48DBFA8A)
>> >>> Keyserver: ? pgpkeys.pca.dfn.de
>> >>> Fingerprint:
>> >>> 477D F057 1BD4 1AE7 8A54 8679 6690 E2EC 48DB FA8A
>> >>> __________________________________________________
>> >>> _______________________________________________
>> >>> Devl mailing list
>> >>> Devl at freenetproject.org
>> >>> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>> >>
>> >
>> >
>> > _______________________________________________
>> > Devl mailing list
>> > Devl at freenetproject.org
>> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>> >
>>
>>
>>
>> --
>> __________________________________________________
>> GnuPG key: ? (0x48DBFA8A)
>> Keyserver: ? pgpkeys.pca.dfn.de
>> Fingerprint:
>> 477D F057 1BD4 1AE7 8A54 8679 6690 E2EC 48DB FA8A
>> __________________________________________________
>> _______________________________________________
>> Devl mailing list
>> Devl at freenetproject.org
>> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
>
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
--
__________________________________________________
GnuPG key: (0x48DBFA8A)
Keyserver: pgpkeys.pca.dfn.de
Fingerprint:
477D F057 1BD4 1AE7 8A54 8679 6690 E2EC 48DB FA8A
__________________________________________________
