ContentFilterInsert isn't quite ready to merge either, sorry I didn't get around to it until now. However you should probably prioritise finishing the ogg filter as we've discussed off-list.
sajack/ContentFilterInsert: (at 9aa0c5bc9d4259f4d76d17dfb43f586b0edbd8a8) - Optionally filter data on insert. - FilterData option on FCP puts (both dir and file). - Uploads through fproxy are not filtered. - If filtering is asked for and no MIME type, guess it from filename. - If filtering fails during insert, fail with a new error. - Simple inserts from plugins via HLSC are not filtered. 34c47ff8711115bfe3af34954b6490995a12a4f3 - targetFilename can be null d33ca5df361a7ddffe6997e367608022f43c1bbd - this is wrong, they should be filled in. It may just be JPEG, not sure. General issue: What we want on filtering on insert is not the same as what we want on filtering on request. Some filters e.g. JPEG have the ability to do different things for inserts (e.g. strip EXIF). General issue: You need to use the MIME type produced by the filter. This is important for e.g. charset detection in HTML. Inserts do need to worry about this because it makes requests more efficient if we know the charset in advance. General issue: It would be nice to have the option to filter stuff in uploads from fproxy. This does not block merging. General issue: ClientPutDiskDir does not filter, you pass false in the relevant constructor even though you support it on the message. InsertFilterCallback - is it safe to return null from e.g. processTag? Doesn't that wipe the tag out? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20100814/b72dfba2/attachment.pgp>
