On Saturday 12 December 2009 05:43:23 Daniel Cheng wrote: > On Sat, Dec 12, 2009 at 7:48 AM, Juiceman <juiceman69 at gmail.com> wrote: > > > > > > > On Fri, Dec 11, 2009 at 1:16 PM, Ian Clarke <ian at locut.us> wrote: > > > >> Ideally we should have a default shared configuration for formatting, > >> ie. we should commit a common Eclipse project file. If others are > >> using something other than Eclipse, they'll need to persuade it to > >> keep the existing formatting. > >> > >> Ian. > >> > >> On Fri, Dec 11, 2009 at 8:25 AM, Daniel Cheng <j16sdiz+freenet at > >> gmail.com<j16sdiz%2Bfreenet at gmail.com>> > >> wrote: > >> > Juiceman, > >> > > >> > Please *DO NOT* fix the source formatting just for the source > >> formatting. > >> > > >> > When you do that, you would mess up `git blame`, make it much harder > >> > to trace who and why a line/method was introduced. > >> > > >> > > >> > Daniel > >> > > > > I'm sorry, I was just trying to be helpful. I'll refrain from cleaning up > > the source code. > > > > I agree with Ian that a coding style standard should be used. > > > > IMHO, a good chuck of Freenet's code is written so densely it is hard to > > read. Also there is a disturbing lack of brackets which could lead to > > hidden bugs, no? > > > > I agree the freenet code is too dense but clean-up-only patches like this do > more harm then good. > > In eclipse, there is an option "On save" --> "Format modified code only". > I don't know if netbeans have simliar option or not.
IMHO commits which mix cleanup and functional changes are hard to read. Which matters more than whether git blame works. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20100108/3bc53bc5/attachment.pgp>
